DOC: Improved the docstring of Series.str.findall #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jcontesti, can you open the PR directly in the pandas repo (https://github.com/pandas-dev/pandas)? (it was in the first guidelines to do it here, but I think we changed our mind about that) |
|
Yes, sorry about that @jcontesti, it was a last minute change. I just updated the documentation: Thanks for the pull request, you're the first one to send it. :) We'll give you more feedback in the pandas repo. |
|
PR in the pandas repo done (pandas-dev#19982). @datapythonista BTW, the documentation still shows https://github.com/python-sprints/pandas as the repo to PR. |
|
Good catch @jcontesti, thanks for pointing out. It should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstring assigned to PyData Mallorca in Pandas Documentation Sprint.
Please, any indication to improve our PR will be appreciated!
Happy to contribute :-)